New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pydaikin version #18413

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
4 participants
@fredrike
Contributor

fredrike commented Nov 12, 2018

Description:

Related issue (if applicable): fixes #13111

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@fabaff

fabaff approved these changes Nov 12, 2018

Thanks 🐦

@fabaff fabaff merged commit c6683cb into home-assistant:dev Nov 12, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.039%
Details

@wafflebot wafflebot bot removed the in progress label Nov 12, 2018

@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 12, 2018

Found an issue in the new pydaikin, should I open a new pr?

@fabaff

This comment has been minimized.

Member

fabaff commented Nov 12, 2018

Yes, please.

@fabaff

This comment has been minimized.

Member

fabaff commented Nov 12, 2018

Sorry, if I was too fast.

@fredrike fredrike referenced this pull request Nov 12, 2018

Merged

Daikin fixes #18415

2 of 2 tasks complete

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

balloob added a commit that referenced this pull request Nov 15, 2018

@balloob balloob referenced this pull request Nov 15, 2018

Merged

0.82.1 #18481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment