New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smhi docstrings #18414

Merged
merged 4 commits into from Nov 13, 2018

Conversation

Projects
None yet
4 participants
@fabaff
Member

fabaff commented Nov 12, 2018

Description:

  • Fix docstrings
  • Add missing docstring
  • Fix ordering of imports
  • Remove line breaks

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
config_entry: ConfigEntry,
config_entries) -> bool:
async def async_setup_entry(
hass: HomeAssistant, config_entry: ConfigEntry, config_entries) -> bool:

This comment has been minimized.

@houndci-bot

houndci-bot Nov 12, 2018

line too long (80 > 79 characters)

@MartinHjelmare

Looks good! Just a typo.

Show resolved Hide resolved homeassistant/components/smhi/config_flow.py Outdated

@MartinHjelmare MartinHjelmare changed the title from Fix docstrings to Fix smhi docstrings Nov 13, 2018

@MartinHjelmare MartinHjelmare merged commit 7113ec6 into dev Nov 13, 2018

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.039%
Details

@wafflebot wafflebot bot removed the in progress label Nov 13, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Fix smhi docstrings (home-assistant#18414)
* Fix docstrings

* Fix lint

* Fix another typo

* Fix mobile phone edit

@Danielhiversen Danielhiversen deleted the smhi branch Nov 14, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment