New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daikin fixes #18415

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@fredrike
Contributor

fredrike commented Nov 12, 2018

Description:

Related issue: #12000, pydaikin==0.6 does not expect f_dir and f_rate to be set.

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 12, 2018

Related to #18413

@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 12, 2018

@fabaff you are free to merge this now, I've verified and it is correct now.

@fabaff

fabaff approved these changes Nov 13, 2018

Thanks 🐦

@fabaff fabaff merged commit 996da72 into home-assistant:dev Nov 13, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.039%
Details

@wafflebot wafflebot bot removed the in progress label Nov 13, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Daikin fixes (home-assistant#18415)
* updated pydaikin version

* some Daikin models does not support fan settings

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment