New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for 1. generation mill heater #18423

merged 4 commits into from Nov 14, 2018


None yet
3 participants

Danielhiversen commented Nov 13, 2018


Improve support for 1. gen mill heater


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/
  • New files were added to .coveragerc.

Danielhiversen added some commits Nov 12, 2018

@@ -177,6 +181,8 @@ def current_operation(self):
def operation_list(self):
"""List of available operation modes."""
if self._heater.is_gen1:
return [STATE_HEAT]

This comment has been minimized.


MartinHjelmare Nov 13, 2018


If it only supports one mode, it doesn't support changing operation mode.

@Danielhiversen Danielhiversen merged commit 00235cf into dev Nov 14, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
coverage/coveralls Coverage increased (+0.003%) to 93.048%

@wafflebot wafflebot bot removed the in progress label Nov 14, 2018

@Danielhiversen Danielhiversen deleted the mill_gen1 branch Nov 14, 2018

@balloob balloob referenced this pull request Nov 29, 2018


0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment