New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Magicseaweed sensor #18446

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@jcconnell
Contributor

jcconnell commented Nov 13, 2018

Description:

I've incremented the python-magicseaweed library to include some minor changes. The attributes dictionary will now include the direction of the swell.

Related issue (if applicable):
A home assistant user requested that swell direction be included in the attributes of this sensor. The python-magicseaweed library has been updated to include this change.

Pull request in home-assistant.io with documentation (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • [x ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

jcconnell added some commits Nov 13, 2018

@fabaff

fabaff approved these changes Nov 13, 2018

Thanks 🐦

@fabaff fabaff merged commit 291fba0 into home-assistant:dev Nov 13, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.047%
Details

@wafflebot wafflebot bot removed the in progress label Nov 13, 2018

@jcconnell

This comment has been minimized.

Contributor

jcconnell commented Nov 13, 2018

Thank you!

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment