New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log delay and wait_template steps in scripts #18448

Merged
merged 3 commits into from Nov 19, 2018

Conversation

Projects
None yet
4 participants
@pnbruckner
Contributor

pnbruckner commented Nov 13, 2018

Description:

Help improve script debugging by logging delay and wait_template steps in scripts. Without these steps being logged, users have to guess if/when they have executed. This can be particularly problematic if the script has multiple wait_templates without an interim step that is logged. In this case one cannot easily guess which wait_template the script might be "stuck" in, or when individual wait_templates actually complete.

Related issue (if applicable): none

Pull request in home-assistant.io with documentation (if applicable): none

Example entry for configuration.yaml (if applicable):

script:
  my_script:
    sequence:
      - service: A_SERVICE # This step is logged
      - wait_template: SOME_WAIT # This step is NOT logged
      - delay: SOME_DELAY # This step is NOT logged
      - wait_template: SOME_OTHER_WAIT # This step is NOT logged
      - service: ANOTHER_SERVICE # This step is logged

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

pnbruckner added some commits Nov 13, 2018

Log delay and wait_template steps in scripts
Help improve script debugging by logging delay and wait_template steps in scripts.

@pnbruckner pnbruckner requested a review from home-assistant/core as a code owner Nov 13, 2018

@homeassistant homeassistant added the core label Nov 13, 2018

@wafflebot wafflebot bot added the in progress label Nov 13, 2018

@pnbruckner

This comment has been minimized.

Contributor

pnbruckner commented Nov 15, 2018

Any idea why it's stuck on waiting for cla-bot? I signed the cla a long time ago.

@balloob balloob merged commit 83b4e56 into home-assistant:dev Nov 19, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.05%
Details

@wafflebot wafflebot bot removed the in progress label Nov 19, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 19, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Bumped ghlocalapi to 0.1.0 (home-assistant#18584)
  Prefix all xiaomi_aqara events (home-assistant#17354)
  Fix MQTT async_added_to_hass (home-assistant#18575)
  Add mikrotik SSL support (home-assistant#17898)
  Reconfigure MQTT binary_sensor component if discovery info is changed (home-assistant#18169)
  Darksky: Expose missing conditions for day 0 forecast (home-assistant#18312)
  Update pyhomematic to 0.1.52 and add features for lights (home-assistant#18499)
  Fix for epson state not updating (home-assistant#18357)
  Support for Point component (home-assistant#17466)
  Template binary sensor to not track all state changes (home-assistant#18573)
  Correct cached stale device tracker handling (home-assistant#18572)
  Add support for sessions (home-assistant#18518)
  Remove turn_on and turn_off feature for clients (home-assistant#18234)
  Log delay and wait_template steps in scripts (home-assistant#18448)
  Logbook speedup (home-assistant#18376)
  Avoid race in entity_platform.async_add_entities() (home-assistant#18445)
  Fix small issue related to topic prefix (home-assistant#18512)
  Enable native support + ADB authentication for Fire TV (home-assistant#17767)
  Re-adding the season attribute (home-assistant#18523)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment