New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTT Sensor #18449

Merged
merged 13 commits into from Dec 17, 2018

Conversation

Projects
None yet
6 participants
@eliseomartelli
Copy link
Contributor

eliseomartelli commented Nov 13, 2018

Description:

Added a sensor to retrieve the next bus at the stop (from GTT, Gruppo Torinese Trasporti, the public transportation service of Turin, Italy)

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: gtt
    stop: '1080'
    bus: '58B'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Pull request for documentation: #7504
If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Nov 13, 2018

Hi @eliseomartelli,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Show resolved Hide resolved homeassistant/components/sensor/gtt.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/gtt.py Outdated

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 13, 2018

@eliseomartelli eliseomartelli referenced this pull request Nov 14, 2018

Merged

Added GTT Sensor documentation #7504

2 of 2 tasks complete

@eliseomartelli eliseomartelli changed the title added gtt sensor Added GTT Sensor Nov 14, 2018

Show resolved Hide resolved homeassistant/components/sensor/gtt.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/gtt.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/gtt.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/gtt.py Outdated

eliseomartelli added some commits Nov 13, 2018

@eliseomartelli eliseomartelli force-pushed the eliseomartelli:gtt-sensor branch from 00a9a91 to d7c0805 Dec 14, 2018

@MartinHjelmare MartinHjelmare changed the title Added GTT Sensor Add GTT Sensor Dec 14, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 14, 2018

Can be merged when build passes.

eliseomartelli added some commits Dec 14, 2018

fix

@cgarwood cgarwood merged commit 6e26713 into home-assistant:dev Dec 17, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on gtt-sensor at 92.889%
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add GTT Sensor (home-assistant#18449)
* added gtt sensor

* removed trailing space

* updated requirements_all

* fixed two errors in the code style

* fixed imperative in docstring

* disabled pylint false positive

* fixed description on top of the file

* added files to .coveragerc

* fixes

* linting

* fixed linting 👍

* left a trailing space, now it's gone.

* fix

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment