New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rainmachine to the device registry #18452

Merged
merged 3 commits into from Nov 15, 2018

Conversation

@bachya
Contributor

bachya commented Nov 14, 2018

Description:

This PR adds RainMachine to the device registry.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

rainmachine:
  ip_address: !secret rainmachine_host
  password: !secret rainmachine_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@bachya bachya force-pushed the bachya:rainmachine-device-registry branch from d3933e2 to e3cc0e1 Nov 14, 2018

@bachya bachya changed the title from WIP: Add Rainmachine to the device registry to Add Rainmachine to the device registry Nov 14, 2018

@MartinHjelmare

Great! Can be merged when build passes.

@bachya bachya merged commit 4446b15 into home-assistant:dev Nov 15, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.046%
Details

@wafflebot wafflebot bot removed the in progress label Nov 15, 2018

@bachya bachya deleted the bachya:rainmachine-device-registry branch Nov 15, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment