New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mikrotik method setting optional as intended #18454

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@WoLpH
Contributor

WoLpH commented Nov 14, 2018

Pull request #17852 accidently made the method setting required.

Description:

Pull request #17852 accidently made the method setting required while it was intended to be optional. This tiny change fixes that :)

Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable):

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: mikrotik
    host: IP_ADDRESS
    username: ADMIN_USERNAME
    password: ADMIN_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Made `method` setting optional as intended
Pull request #17852 accidently made the `method` setting required.

@wafflebot wafflebot bot added the in progress label Nov 14, 2018

@MartinHjelmare MartinHjelmare changed the title from Made `method` setting optional as intended to Make mikrotik method setting optional as intended Nov 14, 2018

@MartinHjelmare MartinHjelmare merged commit 80e616c into home-assistant:dev Nov 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.047%
Details

@wafflebot wafflebot bot removed the in progress label Nov 14, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment