New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ness alarm control panel using nessclient #18463

Merged
merged 12 commits into from Jan 1, 2019

Conversation

@nickw444
Copy link
Contributor

nickw444 commented Nov 14, 2018

Description:

Adds new ness D8x/D16x alarm platform using nessclient client library. Underlying library takes advantage of the Ness D8x/D16x ASCII protocol

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7630

Example entry for configuration.yaml (if applicable):

ness_alarm:
  host: alarm.local
  port: 2401
  zones:
    - name: Garage
      id: 1
    - name: Storeroom
      id: 2
    - name: Kitchen
      id: 3
    - name: Front Entrance
      id: 4

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated

@frenck frenck added the docs-missing label Nov 19, 2018

@nickw444 nickw444 force-pushed the nickw444:nwhyte/ness-alarm branch from bd2b620 to ce9ac8b Nov 23, 2018

Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/binary_sensor/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/binary_sensor/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/binary_sensor/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/alarm_control_panel/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/alarm_control_panel/test_ness_alarm.py Outdated

@nickw444 nickw444 referenced this pull request Nov 25, 2018

Merged

Add ness alarm control panel #7630

2 of 2 tasks complete

@nickw444 nickw444 changed the title WIP: Add ness alarm control panel using pyness232 Add ness alarm control panel using pyness232 Nov 25, 2018

@nickw444

This comment has been minimized.

Copy link
Contributor

nickw444 commented Nov 30, 2018

Hi @frenck this pull request is ready for review. It seems the labels and wip build status hasn’t been updated since I renamed it and finalised the code.

Cheers 🙂

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

In general looks good. Tests should take a different approach though, and be written more like integration tests which is our standard.

Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved tests/components/alarm_control_panel/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/alarm_control_panel/test_ness_alarm.py Outdated
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 9, 2018

To remove WIP label, rebase and reword the commit messages that contain WIP.

@nickw444 nickw444 referenced this pull request Dec 19, 2018

Closed

cli syntax error #15

@nickw444 nickw444 force-pushed the nickw444:nwhyte/ness-alarm branch from 99bfb6e to 6736cc9 Dec 24, 2018

Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/test_ness_alarm.py Outdated

@nickw444 nickw444 force-pushed the nickw444:nwhyte/ness-alarm branch from faf6ea5 to 30243bc Dec 27, 2018

@nickw444 nickw444 changed the title Add ness alarm control panel using pyness232 Add ness alarm control panel using nessclient Dec 27, 2018

nickw444 added some commits Dec 27, 2018

.
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 30, 2018

Please don't squash commits after review has started to make it easier for readers to track changes.

Show resolved Hide resolved homeassistant/components/binary_sensor/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved homeassistant/components/ness_alarm.py Outdated
Show resolved Hide resolved tests/components/alarm_control_panel/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/binary_sensor/test_ness_alarm.py Outdated
Show resolved Hide resolved tests/components/binary_sensor/test_ness_alarm.py Outdated

nickw444 added some commits Dec 31, 2018

@nickw444 nickw444 force-pushed the nickw444:nwhyte/ness-alarm branch from 7958411 to a6933ff Dec 31, 2018

Show resolved Hide resolved .coveragerc Outdated
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit 5aa2bd8 into home-assistant:dev Jan 1, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.063%
Details

@wafflebot wafflebot bot removed the in progress label Jan 1, 2019

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 2, 2019

Add ness alarm control panel using nessclient (home-assistant#18463)
* Add ness alarm control panel using nessclient

* indenting

* .

* Remove availability functionality, will improve and add back in another PR

* Use call_count

* lint

* lint

* Review changes

* Lint

* Bump nessclient to 0.9.8

* Bump nessclient to 0.9.9

* Remove from .coveragerc

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 3, 2019

Add ness alarm control panel using nessclient (home-assistant#18463)
* Add ness alarm control panel using nessclient

* indenting

* .

* Remove availability functionality, will improve and add back in another PR

* Use call_count

* lint

* lint

* Review changes

* Lint

* Bump nessclient to 0.9.8

* Bump nessclient to 0.9.9

* Remove from .coveragerc

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 3, 2019

Merge branch 'dev' into current
* dev:
  Adds ability to calibrate temperature for BME680 (home-assistant#19684)
  Bumping aioasuswrt version to 1.1.17 (home-assistant#19714)
  Bump pyotgw to 0.4b1 (home-assistant#19715)
  Envisalink pgm (home-assistant#19499)
  Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
  Add ness alarm control panel using nessclient (home-assistant#18463)
  Add support for color_temp_command_template in MQTT light component (home-assistant#19675)
  Improve rflink coverage (home-assistant#19596)
  Luftdaten traceback (home-assistant#19666)
  Fix london_underground issue (home-assistant#19642)
  Add IDTECK proximity card component (home-assistant#18309)
  Fix homekit_controller pairing regression (home-assistant#19654)
  Fix error in got_connected for remote.harmony (home-assistant#19662)
  Fix exception checking for next dublin bus (home-assistant#19663)
  Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number (home-assistant#19644)
  pytraccar version bump (home-assistant#19659)
  Suppress traceback if network is not available

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment