New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Freebox component with sensors and device tracker #18472

Merged
merged 22 commits into from Dec 27, 2018

Conversation

@SNoof85
Copy link
Contributor

SNoof85 commented Nov 14, 2018

Description:

This will add Freebox component with sensor and device_tracker rather than only existing device_tracker.

This is a breaking change:
Static configuration for freebox in device_tracker section must be deleted. Only the config of Freebox component is needed.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7521

Example entry for configuration.yaml (if applicable):

freebox:
  host: fbx1234.fbxos.fr
  port: 443

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
Show resolved Hide resolved homeassistant/components/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/device_tracker/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/device_tracker/freebox.py Outdated

@SNoof85 SNoof85 referenced this pull request Nov 15, 2018

Merged

Freebox component with sensor and device tracker platforms #7521

2 of 2 tasks complete

@SNoof85 SNoof85 changed the title WIP : Add Freebox component with sensors and device tracker Add Freebox component with sensors and device tracker Nov 15, 2018

@SNoof85

This comment has been minimized.

Copy link
Contributor

SNoof85 commented Nov 21, 2018

One issue to fix. Going back to WIP.

@SNoof85 SNoof85 changed the title Add Freebox component with sensors and device tracker WIP Add Freebox component with sensors and device tracker Nov 21, 2018

@SNoof85

This comment has been minimized.

Copy link
Contributor

SNoof85 commented Nov 28, 2018

The issue must be fixed in aiopyfreebox. Currently working on it with the owner. As soon as the new package will be released i'll rework this PR to fix the needed version number of aiofreepybox.

SNoof85 added some commits Nov 9, 2018

@stilllman

This comment has been minimized.

Copy link
Contributor

stilllman commented Dec 4, 2018

New version of aiofreepybox (0.0.6) has been published on PyPI.

SNoof85 added some commits Dec 11, 2018

SNoof85 added some commits Dec 11, 2018

@SNoof85 SNoof85 changed the title WIP Add Freebox component with sensors and device tracker Add Freebox component with sensors and device tracker Dec 11, 2018

Show resolved Hide resolved homeassistant/components/device_tracker/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/device_tracker/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/device_tracker/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/freebox.py Outdated
Show resolved Hide resolved homeassistant/components/device_tracker/freebox.py Outdated

SNoof85 added some commits Dec 25, 2018

Fix get_device_name
Thx for the hint Martin
@SNoof85

This comment has been minimized.

Copy link
Contributor

SNoof85 commented Dec 25, 2018

Almost all fixed except one where i would need a hint ;)

SNoof85 added some commits Dec 26, 2018

@SNoof85

This comment has been minimized.

Copy link
Contributor

SNoof85 commented Dec 26, 2018

All RFC addressed and conflicts too.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Good! Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 699a38d into home-assistant:dev Dec 27, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.049%
Details

@wafflebot wafflebot bot removed the in progress label Dec 27, 2018

@SNoof85 SNoof85 deleted the SNoof85:freebox branch Dec 30, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment