New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug for receivers without support for new command #18478

Merged
merged 2 commits into from Nov 15, 2018

Conversation

Projects
None yet
5 participants
@leothlon
Contributor

leothlon commented Nov 15, 2018

Description:

Fixing error on receivers that don't support the new command

Related issue (if applicable): fixes #18353

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@bachya bachya merged commit afb3a52 into home-assistant:dev Nov 15, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.055%
Details

@wafflebot wafflebot bot removed the in progress label Nov 15, 2018

@bachya

This comment has been minimized.

Contributor

bachya commented Nov 15, 2018

Thanks! 😎

@svkowalski

This comment has been minimized.

svkowalski commented Nov 15, 2018

I have also started seeing this issue on my Onkyo TX-NR525. Thanks for the quick work on a fix. It may be worth noting that I only see these errors if my Onkyo was active/on at the time that I restarted HA.

@TonyApuzzo

This comment has been minimized.

TonyApuzzo commented Dec 7, 2018

Unfortunately, my TX-8050 Network Receiver (not an AVR, just a stereo) 2011 model year, crashes even with this patch. I grabbed the older component source (pre 0.82.0) and dropped it into ./config/custom_components and it works for my older receiver.

The symptom is that it totally crashes the network remote control on the receiver. Have to unplug and replug in the receiver to reboot the internal CPU.

The diffs between versions are pretty complicated so not sure where to start trying to track down the culprit but this PR didn't solve the problem on my TX-8050.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment