New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban systemair-savecair #18483

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@balloob
Member

balloob commented Nov 15, 2018

Description:

This dependency contains code to mutate Home Assistant to work around how we architect the system and which we enforce in Home Assistant.

https://github.com/perara/python-systemair-savecair/blob/d906a0f49e2ddec7e359d7f43b107f62f63dadac/systemair/savecair/client.py#L58-L74

image

@balloob balloob force-pushed the ban-systemair branch from c5dad24 to eff5547 Nov 16, 2018

@pvizeli pvizeli merged commit 24db2b6 into dev Nov 16, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.047%
Details

@wafflebot wafflebot bot removed the in progress label Nov 16, 2018

@pvizeli pvizeli deleted the ban-systemair branch Nov 16, 2018

alex3305 added a commit to alex3305/home-assistant that referenced this pull request Nov 17, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment