New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up left-behind dispatcher handlers when removing RainMachine #18488

Merged
merged 2 commits into from Nov 17, 2018

Conversation

@bachya
Contributor

bachya commented Nov 15, 2018

Description:

The current implementation of RainMachine leaves behind some active dispatcher handlers when removing the component via the UI. This PR cleans that up (and centralizes that logic in the component, rather than across the platforms).

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

rainmachine:
  ip_address: !secret rainmachine_host
  password: !secret rainmachine_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@MartinHjelmare MartinHjelmare merged commit e73b9b9 into home-assistant:dev Nov 17, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 93.054%
Details

@wafflebot wafflebot bot removed the in progress label Nov 17, 2018

alex3305 added a commit to alex3305/home-assistant that referenced this pull request Nov 17, 2018

Clean up left-behind dispatcher handlers when removing RainMachine (h…
…ome-assistant#18488)

* Clean up left-behind dispatcher handlers when removing RainMachine

* Member comments

@bachya bachya deleted the bachya:rainmachine-dispatcher branch Nov 19, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment