New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MyQ platform async #18489

Merged
merged 4 commits into from Nov 18, 2018

Conversation

Projects
None yet
3 participants
@bachya
Contributor

bachya commented Nov 15, 2018

Description:

This PR bumps pymyq to 1.0.0, which makes the integration async.

This PR should be merged before continuing on with #17535.

CC @arraylabs

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

cover:
  - platform: myq
    username: !secret myq_email
    password: !secret myq_password
    type: chamberlain

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

bachya added some commits Oct 22, 2018

Show resolved Hide resolved homeassistant/components/cover/myq.py Outdated
Show resolved Hide resolved homeassistant/components/cover/myq.py Outdated
Show resolved Hide resolved homeassistant/components/cover/myq.py Outdated
@MartinHjelmare

should_poll property can be removed too.

Show resolved Hide resolved homeassistant/components/cover/myq.py Outdated

@MartinHjelmare MartinHjelmare merged commit 8f59be2 into home-assistant:dev Nov 18, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.056%
Details

@wafflebot wafflebot bot removed the in progress label Nov 18, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 18, 2018

@bachya bachya deleted the bachya:myq-async branch Nov 19, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment