New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes that broke UI #18495

Merged
merged 3 commits into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@dapowers87
Contributor

dapowers87 commented Nov 15, 2018

Description:

Commit 1cbb5b8, "State is set to UNKNOWN rather than ON in order to make UI have an pl...", made a change that caused the UI to show the device as "Unknown" when it was turned on in order. There was never a scenario where the TV would be in STATE_ON. I reverted the changes made.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

homeassistant commented Nov 15, 2018

Hi @dapowers87,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@@ -104,7 +105,7 @@ def __init__(self, host, port, name, timeout, mac, uuid):
self._muted = False
# Assume that the TV is in Play mode
self._playing = True
self._state = None
self._state = STATE_UNKNOWN

This comment has been minimized.

@balloob

balloob Nov 19, 2018

Member

Keep this as None, we should never use STATE_UNKNOWN as that will be dealt with automatically in the entity helper class.

@balloob

This comment has been minimized.

Member

balloob commented Nov 19, 2018

Yeah that's weird, if a TV is on, it shouldn't be unknown 🤔

dapowers87 added some commits Nov 19, 2018

@balloob balloob merged commit d88040e into home-assistant:dev Nov 20, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 93.029%
Details

@wafflebot wafflebot bot removed the in progress label Nov 20, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 20, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Improve available for Mill heater (home-assistant#18597)
  Z-Wave Lock Config Entry Support (home-assistant#18209)
  Add support for Daikin BRP069B41 (home-assistant#18564)
  Hass.io config check (home-assistant#18576)
  Revert changes that broke UI (home-assistant#18495)
  Add websocket calls to shopping-list (home-assistant#18392)
  Bump Python-Nest to 4.0.5 (home-assistant#18580)
  Adds light switch platform (home-assistant#18562)
  Added unique id to all Wink devices. (home-assistant#18589)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment