Improve update performance #18518
Merged
Improve update performance #18518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for sessions to keep connection open with August portal, improving performance. py-august version increased to 0.7.0
ghost
added
the
pvizeli
reviewed
Nov 19, 2018
|
|
||
| self._hass.bus.listen_once( | ||
| EVENT_HOMEASSISTANT_STOP, august_api_stop) | ||
| _LOGGER.debug("Registered for HASS stop event") |
There was a problem hiding this comment.
Please add this object a stop method and register this inside setup. It's a bad practice to do this inside a init
|
Oh no 🙈 I was too fast Pascal |
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for sessions to keep connection open with August portal, improving performance.
py-august version increased to 0.7.0
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
requirements_all.txtby runningscript/gen_requirements_all.py.