New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve update performance #18518

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
4 participants
@ehendrix23
Contributor

ehendrix23 commented Nov 16, 2018

Description:

Added support for sessions to keep connection open with August portal, improving performance.
py-august version increased to 0.7.0

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
Add support for sessions
Added support for sessions to keep connection open with August portal, improving performance.
py-august version increased to 0.7.0
self._hass.bus.listen_once(
EVENT_HOMEASSISTANT_STOP, august_api_stop)
_LOGGER.debug("Registered for HASS stop event")

This comment has been minimized.

@pvizeli

pvizeli Nov 19, 2018

Member

Please add this object a stop method and register this inside setup. It's a bad practice to do this inside a init

This comment has been minimized.

@ehendrix23

ehendrix23 Nov 19, 2018

Contributor

@pvizeli Created PR #18582 for this, can you please check and confirm that this is indeed the way it should be. :-)

@balloob new PR #18582 created to address the comment.

@balloob balloob merged commit 9fa34f0 into home-assistant:dev Nov 19, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.056%
Details

@wafflebot wafflebot bot removed the in progress label Nov 19, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 19, 2018

Oh no 🙈 I was too fast Pascal

@ehendrix23 ehendrix23 deleted the ehendrix23:Add-session-support branch Nov 19, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 19, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Bumped ghlocalapi to 0.1.0 (home-assistant#18584)
  Prefix all xiaomi_aqara events (home-assistant#17354)
  Fix MQTT async_added_to_hass (home-assistant#18575)
  Add mikrotik SSL support (home-assistant#17898)
  Reconfigure MQTT binary_sensor component if discovery info is changed (home-assistant#18169)
  Darksky: Expose missing conditions for day 0 forecast (home-assistant#18312)
  Update pyhomematic to 0.1.52 and add features for lights (home-assistant#18499)
  Fix for epson state not updating (home-assistant#18357)
  Support for Point component (home-assistant#17466)
  Template binary sensor to not track all state changes (home-assistant#18573)
  Correct cached stale device tracker handling (home-assistant#18572)
  Add support for sessions (home-assistant#18518)
  Remove turn_on and turn_off feature for clients (home-assistant#18234)
  Log delay and wait_template steps in scripts (home-assistant#18448)
  Logbook speedup (home-assistant#18376)
  Avoid race in entity_platform.async_add_entities() (home-assistant#18445)
  Fix small issue related to topic prefix (home-assistant#18512)
  Enable native support + ADB authentication for Fire TV (home-assistant#17767)
  Re-adding the season attribute (home-assistant#18523)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment