New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill lib #18529

Merged
merged 3 commits into from Nov 17, 2018

Conversation

Projects
None yet
3 participants
@Danielhiversen
Member

Danielhiversen commented Nov 17, 2018

Description:

Fix bug in mill lib:
https://github.com/Danielhiversen/pymill/commits/master
Add a attr to the sensor.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Danielhiversen added some commits Nov 15, 2018

lib

@Danielhiversen Danielhiversen merged commit 3f747f1 into dev Nov 17, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.056%
Details

@wafflebot wafflebot bot removed the in progress label Nov 17, 2018

@Danielhiversen Danielhiversen deleted the mill_attr_lib branch Nov 17, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment