New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device_id configuration option to Bluetooth tracker #18539

Merged
merged 2 commits into from Dec 25, 2018

Conversation

Projects
None yet
3 participants
@imotov
Copy link
Contributor

imotov commented Nov 17, 2018

Description:

Makes the device id that bluetooth tracker is using configurable instead
of using the first available device.

Related issue (if applicable): feature request https://community.home-assistant.io/t/allow-bluetooth-usb-device-to-be-specified-for-use-with-device-tracking/15696

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7560

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: bluetooth_tracker
    device_id: 1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass (in tox tests pass but I am getting ERROR: typing: commands failed error for the same two unrelated files as I get in the dev branch)
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Bluetooth tracker: add device_id configuration option
Makes the device id that bluetooth tracker is using configurable instead 
of using the first available device.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Nov 17, 2018

Hi @imotov,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@wafflebot wafflebot bot added the in progress label Nov 17, 2018

@imotov imotov referenced this pull request Nov 17, 2018

Merged

Add device_id to device_tracker.bluetooth configuration #7560

2 of 2 tasks complete

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 17, 2018

@fabaff fabaff changed the title Bluetooth tracker: add device_id configuration option Add device_id configuration option to Bluetooth tracker Nov 18, 2018

@@ -44,11 +50,13 @@ def see_device(mac, name, rssi=None):
see(mac="{}{}".format(BT_PREFIX, mac), host_name=name,
attributes=attributes, source_type=SOURCE_TYPE_BLUETOOTH)

device_id = config.get(CONF_DEVICE_ID, DEFAULT_DEVICE_ID)

This comment has been minimized.

@fabaff

fabaff Nov 18, 2018

Member

The default is already handled during the configuration validation.

Remove unncessary default in config.get
It is already handled in the configuration validation.
@fabaff

fabaff approved these changes Dec 25, 2018

Copy link
Member

fabaff left a comment

Looks good to me 🐦

@fabaff fabaff merged commit b9a0f40 into home-assistant:dev Dec 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.047%
Details

@wafflebot wafflebot bot removed the in progress label Dec 25, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment