New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ambient Weather PWS Sensor component #18551

Merged
merged 17 commits into from Dec 14, 2018

Conversation

Projects
None yet
7 participants
@tmd224
Copy link
Contributor

tmd224 commented Nov 18, 2018

Description:

Adding Ambient Weather PWS Sensor component.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7566

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: ambient_station
    api_key: YOUR_API_KEY
    app_key: YOUR_APP_KEY
    monitored_conditions:
      - tempf
      - winddir
      - windspeedmph
      - windgustmph

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Nov 18, 2018

Hi @tmd224,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Show resolved Hide resolved homeassistant/components/sensor/ambient_station.py
Show resolved Hide resolved man/man1/nosetests.1 Outdated
Show resolved Hide resolved homeassistant/components/sensor/ambient_station.py Outdated

@MartinHjelmare MartinHjelmare changed the title Adding Ambient Weather PWS Sensor component Add Ambient Weather PWS Sensor component Dec 11, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 12, 2018

Coveralls result is flaky. The new module is excluded from coverage calculation.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit d60b7d4 into home-assistant:dev Dec 14, 2018

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 92.889%
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 17, 2018

Merge branch 'dev' into current
* dev:
  Bump pyEight to fix Single Sleeper (home-assistant#19316)
  Add note to issue template regarding frontend issues (home-assistant#19295)
  Add Ambient Weather PWS Sensor component (home-assistant#18551)
  Fix tests

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add Ambient Weather PWS Sensor component (home-assistant#18551)
* Adding ambient_station.py sensor and updating requirements file

* Cleaning up code and fixing flake8 warnings

* Fixing flake8 and pylint warnings

* Adding ambient_station.py sensor and updating requirements file

* Cleaning up code and fixing flake8 warnings

* Fixing flake8 and pylint warnings

* Fixing bug, things are working well now

* removing nosetests file

* Adding changes as requested in pull request home-assistant#18551

* Updating with more change requests from PR code review

* Removing SCAN_INTERVAL from PLATFORM_SCHEMA

* Removing unused import

* Adding platform schema validation for monitored_conditions and conf_units

* Updating link to documentation in doc-string.  File already named in doc repo

* Only setup platform if component can successfully communicate with API

* Inverting check for platform setup success

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@sfgabe

This comment has been minimized.

Copy link

sfgabe commented Jan 10, 2019

Same here. I referred them to the HA documentation and the following was the response:

"Unfortunately, he is wrong. It is one app with many users, not many apps with many users. Thus, he needs to supply you with the app key unique to his application."

@marchingphoenix

This comment has been minimized.

Copy link
Contributor

marchingphoenix commented Jan 10, 2019

@CTLS @sfgabe Please do not have discussions on merged PRs. Please open an issue.

@sfgabe

This comment has been minimized.

Copy link

sfgabe commented Jan 10, 2019

Sorry! Moved here:
#19932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment