New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Daikin BRP069B41 #18564

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@fredrike
Contributor

fredrike commented Nov 18, 2018

Description:

Version bump on pydaikin that adds support for BRP069B4x devices.

Related issue (if applicable): fixes #18563

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@wafflebot wafflebot bot added the in progress label Nov 18, 2018

@fredrike fredrike changed the title from Add support for BRP069B41, fixes #18563 to Add support for BRP069B41, fixes Nov 18, 2018

@fredrike fredrike force-pushed the fredrike:daikin-BRP069B41 branch from f554c16 to 90124f0 Nov 20, 2018

@MartinHjelmare MartinHjelmare changed the title from Add support for BRP069B41, fixes to Add daikin support for BRP069B41 Nov 20, 2018

@MartinHjelmare

Can be merged when build passes.

@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 20, 2018

poing @MartinHjelmare

@fredrike fredrike changed the title from Add daikin support for BRP069B41 to Add support for Daikin BRP069B41 Nov 20, 2018

@MartinHjelmare MartinHjelmare merged commit 3838be4 into home-assistant:dev Nov 20, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 93.02%
Details

@wafflebot wafflebot bot removed the in progress label Nov 20, 2018

@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 20, 2018

@MartinHjelmare what is the release cycle? When will this fix be available to HA (0.82.2?)?

@fredrike fredrike deleted the fredrike:daikin-BRP069B41 branch Nov 20, 2018

@cgarwood

This comment has been minimized.

Member

cgarwood commented Nov 20, 2018

I believe the 0.83 beta is being cut tomorrow, which would include this PR, and then general release will be a week later.

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 20, 2018

Yes, we have a two week release cycle, of which 1 week is beta. So it's two weeks between beta cuts, and two weeks between (minor) releases. Usually there's at least one patch release a couple of days after a minor release. We don't do major releases yet.

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 20, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Improve available for Mill heater (home-assistant#18597)
  Z-Wave Lock Config Entry Support (home-assistant#18209)
  Add support for Daikin BRP069B41 (home-assistant#18564)
  Hass.io config check (home-assistant#18576)
  Revert changes that broke UI (home-assistant#18495)
  Add websocket calls to shopping-list (home-assistant#18392)
  Bump Python-Nest to 4.0.5 (home-assistant#18580)
  Adds light switch platform (home-assistant#18562)
  Added unique id to all Wink devices. (home-assistant#18589)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment