New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud pref for Google unlock #18600

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@balloob
Member

balloob commented Nov 20, 2018

Description:

Move cloud preferences to its own file and add a google_allow_unlock pref.

Frontend: home-assistant/home-assistant-polymer#2073

Example entry for configuration.yaml (if applicable):

cloud:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Nov 20, 2018

@wafflebot wafflebot bot added the in progress label Nov 20, 2018

@balloob balloob merged commit d9c7f77 into dev Nov 20, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on cloud-allow-unlock at 93.03%
Details

@wafflebot wafflebot bot removed the in progress label Nov 20, 2018

@balloob balloob deleted the cloud-allow-unlock branch Nov 20, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 21, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Fibaro components (home-assistant#18487)
  Change channel with play_media instead of select_source (home-assistant#18474)
  Add cloud pref for Google unlock (home-assistant#18600)
  Update Z-Wave Tests asyncio/yield from -> async/await (home-assistant#18599)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

@mindsocket

This comment has been minimized.

mindsocket commented Dec 2, 2018

Is there any documentation to accompany this? If not, should there be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment