New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTPS and basic HTTP authentication for Glances #18608

Merged
merged 2 commits into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@ludeeus
Member

ludeeus commented Nov 21, 2018

Description:

This PR adds support for HTTPS and basic HTTP authentication for the glances sensor.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7596

Example entry for configuration.yaml (if applicable):

sensor:
  platform: glances
  username: my_user
  password: my_pass
  ssl: true
  verify_ssl: false

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@ludeeus ludeeus requested a review from fabaff as a code owner Nov 21, 2018

@wafflebot wafflebot bot added the in progress label Nov 21, 2018

@ludeeus ludeeus changed the title from Add support for HTTPS and basics HTTP authentication for Glances to Add support for HTTPS and basic HTTP authentication for Glances Nov 21, 2018

@ludeeus ludeeus referenced this pull request Nov 21, 2018

Merged

Add documentation for SSL and authentication #7596

2 of 2 tasks complete
@fabaff

fabaff approved these changes Nov 21, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 3cde8dc into home-assistant:dev Nov 21, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.021%
Details

@wafflebot wafflebot bot removed the in progress label Nov 21, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 21, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Upgrade requests to 2.20.1 (home-assistant#18615)
  Fix mqtt cover inverted (home-assistant#18456)
  Update locationsharinglib requirement to 3.0.8 (home-assistant#18612)
  Add support for Panasonic Blu-Ray players (home-assistant#18541)
  Add support for HTTPS and basic HTTP authentication for Glances (home-assistant#18608)
  Add permissions check in service helper (home-assistant#18596)
  Upgrade blinkpy to 0.10.3 (Fixes home-assistant#18341) (home-assistant#18603)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment