New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added qbittorrent sensor platform #18618

Merged
merged 24 commits into from Nov 29, 2018

Conversation

@eliseomartelli
Copy link
Contributor

eliseomartelli commented Nov 21, 2018

Description:

Added a sensor platform to retrieve data from the qBittorrent API.

Documentation PR home-assistant/home-assistant.io#7597

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: qbittorrent
    url: "http://192.168.0.xx:8080"
    username: <username>
    password: <password>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

eliseomartelli added some commits Nov 21, 2018

@frenck

This comment has been minimized.

Copy link
Member

frenck commented Nov 21, 2018

Could not find a matching PR targeting our documentation repository. Adding docs-missing label.

@frenck frenck added the docs-missing label Nov 21, 2018

@eliseomartelli eliseomartelli referenced this pull request Nov 21, 2018

Merged

added qbittorrent sensor documentation #7597

2 of 2 tasks complete

@frenck frenck removed the docs-missing label Nov 21, 2018

eliseomartelli added some commits Nov 22, 2018

@fabaff
Copy link
Member

fabaff left a comment

Just some quick comments.

@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Nov 25, 2018

@fabaff Applied your suggestions :)

eliseomartelli added some commits Nov 25, 2018

eliseomartelli added some commits Nov 25, 2018

Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/qbittorrent.py Outdated

MartinHjelmare and others added some commits Nov 29, 2018

Update homeassistant/components/sensor/qbittorrent.py
Co-Authored-By: eliseomartelli <martely98@gmail.com>
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! @fabaff?

@fabaff

fabaff approved these changes Nov 29, 2018

@fabaff fabaff merged commit 5c026b1 into home-assistant:dev Nov 29, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 92.913%
Details

@wafflebot wafflebot bot removed the in progress label Nov 29, 2018

@eliseomartelli eliseomartelli deleted the eliseomartelli:qbittorrent-sensor branch Nov 29, 2018

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment