New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCN component and light platform #18621

Merged
merged 16 commits into from Dec 28, 2018

Conversation

Projects
None yet
5 participants
@alengwenus
Copy link
Contributor

alengwenus commented Nov 21, 2018

Description:

Implementation of the LCN (Local Control Network). LCN is a well known and popular home automation system from Germany with a broad range of devices, sensors, actuators, and much more.
This PR covers the base component and light platform.

Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7599

Example entry for configuration.yaml (if applicable):

lcn:
  connections:
    - name: myhome
      host: 192.168.2.41
      port: 4114
      username: !secret lcn_username
      password: !secret lcn_password

  lights:
    - name: Living room
      address: myhome.0.7
      output: output1
      dimmable: true
      transition: 5

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@wafflebot wafflebot bot added the in progress label Nov 21, 2018

@alengwenus alengwenus changed the title Initial commit of LCN component and light platform LCN component and light platform Nov 21, 2018

@alengwenus alengwenus referenced this pull request Nov 21, 2018

Merged

Documentation for LCN component and light platform #7599

2 of 2 tasks complete

@alengwenus alengwenus force-pushed the alengwenus:dev_lcn_base branch 4 times, most recently from b6094d0 to a37bb82 Nov 21, 2018

@fabaff
Copy link
Member

fabaff left a comment

Just some comments to get the review started.

Show resolved Hide resolved homeassistant/components/lcn/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/lcn/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/lcn/core.py Outdated
Show resolved Hide resolved homeassistant/components/lcn/core.py Outdated
Show resolved Hide resolved homeassistant/components/lcn/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py Outdated
@alengwenus

This comment has been minimized.

Copy link
Contributor

alengwenus commented Nov 29, 2018

I've made the above changes. Could you re-review, please @fabaff

@alengwenus alengwenus force-pushed the alengwenus:dev_lcn_base branch 3 times, most recently from 473a019 to e6eebef Dec 1, 2018

@alengwenus

This comment has been minimized.

Copy link
Contributor

alengwenus commented Dec 2, 2018

@fabaff : Is there anything I need to do to move this on? Did I miss anything? Please advise.

@pvizeli
Copy link
Member

pvizeli left a comment

Please make a simple lcn.py as a component. I see no reason to split that two files __init__ and core.

@alengwenus alengwenus force-pushed the alengwenus:dev_lcn_base branch from e6eebef to 9178f96 Dec 10, 2018

@alengwenus alengwenus force-pushed the alengwenus:dev_lcn_base branch from 9178f96 to d440943 Dec 15, 2018

@alengwenus

This comment has been minimized.

Copy link
Contributor

alengwenus commented Dec 15, 2018

Thanks for reviewing. I implemented all requested changes @pvizeli , @fabaff . Would you recheck, please. I'd really want to push this forward.

alengwenus added some commits Dec 15, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Also set should_poll to False on the entity.

Show resolved Hide resolved homeassistant/components/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Nice! Some more comments and questions.

Show resolved Hide resolved homeassistant/components/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py Outdated
Show resolved Hide resolved homeassistant/components/light/lcn.py

@alengwenus alengwenus force-pushed the alengwenus:dev_lcn_base branch from f7defae to 3d4477b Dec 28, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit f09cea1 into home-assistant:dev Dec 28, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.049%
Details

@wafflebot wafflebot bot removed the in progress label Dec 28, 2018

@alengwenus

This comment has been minimized.

Copy link
Contributor

alengwenus commented Dec 28, 2018

Thanks a lot @MartinHjelmare! Amazing work!

@alengwenus alengwenus deleted the alengwenus:dev_lcn_base branch Dec 29, 2018

alengwenus added a commit to alengwenus/home-assistant that referenced this pull request Dec 30, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 30, 2018

Merge branch 'dev' into current
* dev: (44 commits)
  Fix ADS light when parameter adsvar_brightness is not set (home-assistant#19636)
  Bump pyHik library to 0.1.9 to improve device support. (home-assistant#19656)
  Use aioharmony for remote.harmony platform (home-assistant#19595)
  Add RaspyRFM switch platform (home-assistant#19130)
  Only bind clusters in ZHA remote entity (home-assistant#19577)
  Use async_configure for ZHA IAS binary sensor (home-assistant#19629)
  Improve Wemo setup speed (home-assistant#19563)
  Support knx operation types (home-assistant#19546)
  Use xml.etree through defusedxml (home-assistant#19640)
  Fix cpu_temp issue on Vero 4K (home-assistant#19638)
  Added events STARTED, RESTARTED AND PAUSED (home-assistant#19516)
  Revert "Bump pyotgw to 0.4b0 (home-assistant#19618)" (home-assistant#19635)
  Upgrade to async_upnp_client==0.13.8 (home-assistant#19634)
  Upgraded pyarlo to 0.2.3 (home-assistant#19626)
  Fix cpu_temp issue on Odroid (home-assistant#19620)
  Bump pyotgw to 0.4b0 (home-assistant#19618)
  Add additional neato alerts and errors (home-assistant#19608)
  LCN component and light platform (home-assistant#18621)
  Systemmonitor - add device_class property (home-assistant#19614)
  Upgrade huawei-lte-api to 1.1.1 (home-assistant#19615)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment