New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ZHA #18629

Merged
merged 4 commits into from Nov 22, 2018

Conversation

@dmulcahey
Copy link
Contributor

dmulcahey commented Nov 22, 2018

Refactor the core of ZHA so that it can be extended without causing issues with things like circular imports.

This PR:

  • splits the helper functions out into their own file
  • splits the entities into their own files
  • corrects a situation where zha_const.populate_data() was called for every device initialization
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! I think we can merge after the one comment is addressed.

@MartinHjelmare MartinHjelmare changed the title refactor ZHA Refactor ZHA Nov 22, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 22, 2018

I think we need to update .coveragerc with the new files.

@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Nov 22, 2018

I think we need to update .coveragerc with the new files.

@MartinHjelmare I’m out with family for a while. I can do it when I get home or you can do it if you don’t want to wait.

@MartinHjelmare MartinHjelmare merged commit 67aa76d into home-assistant:dev Nov 22, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.028%
Details

@wafflebot wafflebot bot removed the in progress label Nov 22, 2018

@MartinHjelmare MartinHjelmare referenced this pull request Nov 22, 2018

Merged

Add config entry for ZHA #18352

3 of 3 tasks complete
@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Nov 22, 2018

Thanks for the assist @MartinHjelmare!

ahayworth added a commit to ahayworth/home-assistant that referenced this pull request Nov 22, 2018

Refactor ZHA (home-assistant#18629)
* refactor ZHA

* lint

* review request

* Exclude more zha modules from coverage

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-refactor branch Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment