New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated webhook_register, version bump pypoint #18635

Merged
merged 2 commits into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@fredrike
Contributor

fredrike commented Nov 22, 2018

Description:

When merged with dev, the hass.components.webhook.async_register changed format.

Pypoint v 1.0.5 had a minor issue.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 22, 2018

@MartinHjelmare, do you know why the binary sensors are shown as unknown?

Edit, found it f2587d9 works as expected.

@MartinHjelmare

Looks good! I'm guessing we want this to be part of 0.83?

@MartinHjelmare MartinHjelmare added this to the 0.83 milestone Nov 22, 2018

@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 22, 2018

Yes it should be part of 0.83, it is a mistake by me (that perhaps should have been spotted during the extensive review 🙈).

@balloob balloob merged commit cccc41c into home-assistant:dev Nov 22, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.019%
Details

@wafflebot wafflebot bot removed the in progress label Nov 22, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 22, 2018

That's why we do betas :)

@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 22, 2018

Great! Thank you for the merge!

What is the time frame for oauth2 authentication via the cloud?

@fredrike fredrike deleted the fredrike:point-0.83 branch Nov 22, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 22, 2018

🙈

ahayworth added a commit to ahayworth/home-assistant that referenced this pull request Nov 22, 2018

Updated webhook_register, version bump pypoint (home-assistant#18635)
* Updated webhook_register, version bump pypoint

* A binary_sensor should be a BinarySensorDevice
@fredrike

This comment has been minimized.

Contributor

fredrike commented Nov 24, 2018

Could we release a 0.83.0b1 to make sure everything is ok?

balloob added a commit that referenced this pull request Nov 26, 2018

Updated webhook_register, version bump pypoint (#18635)
* Updated webhook_register, version bump pypoint

* A binary_sensor should be a BinarySensorDevice

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment