New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove since last boot from systemmonitor sensor #18644

Merged
merged 2 commits into from Nov 23, 2018

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

balloob commented Nov 22, 2018

Description:

We shouldn't store relative times in the state machine. We should only have last_boot (which already exists) and give it the timestamp device class (is an architecture issue for), and then let the UI deal with updating it.

@mbo18

This comment has been minimized.

Copy link

mbo18 commented Nov 23, 2018

Correct me if I’m wrong but last_boot does not currently return a timestamp but a date. So we will lose information here

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Nov 23, 2018

Updated last_boot to be the full timestamp. If people want running time, home-assistant/architecture#39 is going to fix that.

@mbo18 mbo18 referenced this pull request Nov 23, 2018

Closed

Removed since_last_boot #7605

0 of 2 tasks complete

@balloob balloob merged commit c0cf29a into dev Nov 23, 2018

5 of 6 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on monitor-since-last-boot at 93.018%
Details

@wafflebot wafflebot bot removed the in progress label Nov 23, 2018

@balloob balloob deleted the monitor-since-last-boot branch Nov 23, 2018

@mbo18 mbo18 referenced this pull request Nov 23, 2018

Merged

Removed since_last_boot #7612

1 of 2 tasks complete

frenck added a commit to home-assistant/home-assistant.io that referenced this pull request Nov 24, 2018

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment