New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Cleanup Lutron light component #18650

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@cdheiser
Copy link
Contributor

cdheiser commented Nov 23, 2018

Description:

Remove the return value from setup_platform
Convert LutronLight.init to use super() when referencing the parent class.
Change device_state_attributes() to use lowercase snakecase (Rename 'Lutron Integration ID' to 'lutron_integration_id')

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
[Breaking Change] Cleanup Lutron light component
Remove the return value from setup_platform
Convert LutronLight.__init__ to use super() when referencing the parent class.
Change device_state_attributes() to use lowercase snakecase (Rename 'Lutron Integration ID' to 'lutron_integration_id')

@wafflebot wafflebot bot added the in progress label Nov 23, 2018

@balloob balloob merged commit 98f159a into home-assistant:dev Nov 23, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on patch-1 at 93.028%
Details

@wafflebot wafflebot bot removed the in progress label Nov 23, 2018

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

This was referenced Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment