New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow managing cloud webhook #18672

Merged
merged 16 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

balloob commented Nov 24, 2018

Description:

This adds foundation for cloud-extension of webhooks. Allow managing via frontend. Handling incoming webhooks from relayer will be done in another PR.

WIP because I am not done yet with adding tests.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Nov 24, 2018

@wafflebot wafflebot bot added the in progress label Nov 24, 2018

balloob added some commits Nov 4, 2018

@balloob balloob force-pushed the cloud-webhooks branch from 34e1f5f to 3b500e6 Nov 25, 2018

@balloob balloob changed the title WIP: Allow managing cloud webhook Allow managing cloud webhook Nov 25, 2018

balloob added some commits Nov 25, 2018

@balloob balloob merged commit 7848381 into dev Nov 26, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 92.996%
Details

@wafflebot wafflebot bot removed the in progress label Nov 26, 2018

@balloob balloob deleted the cloud-webhooks branch Nov 26, 2018

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment