New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logbook filtering entities #18721

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@balloob
Member

balloob commented Nov 26, 2018

Description:

Fix logbook filtering only events that are related to entities and not logbook_entry events.

Introduced in #18376

Reported by @arsaboo on Discord

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.83 milestone Nov 26, 2018

@wafflebot wafflebot bot added the in progress label Nov 26, 2018

@balloob balloob referenced this pull request Nov 26, 2018

Merged

Logbook speedup #18376

3 of 3 tasks complete

@balloob balloob merged commit 9894eff into dev Nov 26, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 92.99%
Details

@balloob balloob deleted the fix-logbook-filtering branch Nov 26, 2018

@wafflebot wafflebot bot removed the in progress label Nov 26, 2018

balloob added a commit that referenced this pull request Nov 27, 2018

Fix logbook filtering entities (#18721)
* Fix logbook filtering entities

* Fix flaky test

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment