New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy api fix #18733

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@balloob
Member

balloob commented Nov 26, 2018

Description:

With my requirements work I introduced a bug where people connecting with legacy API password wouldn't be able to communicate with Rest API.

This fixes it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

balloob added some commits Nov 26, 2018

@balloob balloob requested a review from home-assistant/core as a code owner Nov 26, 2018

@wafflebot wafflebot bot added the in progress label Nov 26, 2018

@balloob balloob merged commit c2f8dfc into dev Nov 27, 2018

3 of 5 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Nov 27, 2018

@balloob balloob deleted the legacy-api-fix branch Nov 27, 2018

@balloob balloob added this to the 0.83.1 milestone Nov 29, 2018

balloob added a commit that referenced this pull request Nov 29, 2018

Legacy api fix (#18733)
* Set user for API password requests

* Fix tests

* Fix typing

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83.1 #18811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment