New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aioasuswrt sometimes return empty lists #18742

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
5 participants
@kennedyshead
Contributor

kennedyshead commented Nov 27, 2018

Description:

  • If there is no data available it will be an empy list rather than None.
  • Bumping version to take care of telnet reconnect.

Related issue (if applicable): fixes #18728 fixes #18735

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@cgarwood cgarwood merged commit 87507c4 into home-assistant:dev Nov 27, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 92.995%
Details

@wafflebot wafflebot bot removed the in progress label Nov 27, 2018

@balloob balloob added this to the 0.83.3 milestone Dec 3, 2018

balloob added a commit that referenced this pull request Dec 3, 2018

fix aioasuswrt sometimes return empty lists (#18742)
* aioasuswrt sometimes return empty lists

* Bumping aioasuswrt to 1.1.12

@balloob balloob referenced this pull request Dec 3, 2018

Merged

0.83.3 #18958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment