New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more opt-out auth #18854

Merged
merged 2 commits into from Dec 2, 2018

Conversation

@balloob
Copy link
Member

balloob commented Nov 30, 2018

Description:

Until now it was possible to opt-out of the auth. We mainly did this because we didn't update all our tests yet. I realized with the recent legacy auth hiccups (#18844) that we really had to wrap it up or it would linger forever.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob force-pushed the no-opt-out-auth branch from 9ea7993 to 0a4fc6e Nov 30, 2018

@pvizeli

pvizeli approved these changes Dec 2, 2018

@pvizeli pvizeli merged commit d1a6216 into dev Dec 2, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 92.918%
Details

@delete-merged-branch delete-merged-branch bot deleted the no-opt-out-auth branch Dec 2, 2018

@wafflebot wafflebot bot removed the in progress label Dec 2, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 2, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (35 commits)
  Add lightwave components for switches and lights (home-assistant#18026)
  Remove commented out code (home-assistant#18925)
  No more opt-out auth (home-assistant#18854)
  Reconfigure MQTT switch component if discovery info is changed (home-assistant#18179)
  Reconfigure MQTT light component if discovery info is changed (home-assistant#18176)
  Set sensor to unavailable if battery is dead. (home-assistant#18802)
  Fix hdmi_cec entity race (home-assistant#18753)
  Show ANSI color codes in logs in Hass.io (home-assistant#18834)
  bugfix: ensure the `google_assistant` component respects `allow_unlock` (home-assistant#18874)
  Fibaro ubs (home-assistant#18889)
  Restore states when removing/adding entities (home-assistant#18890)
  Optionally do not log template rendering errors (home-assistant#18724)
  Small refactoring of MQTT climate (home-assistant#18814)
  Small refactoring of MQTT alarm (home-assistant#18813)
  Small refactoring of MQTT cover (home-assistant#18850)
  Upgrade keyring to 17.0.0 (home-assistant#18901)
  Upgrade pillow to 5.3.0
  Upgrade ruamel.yaml to 0.15.80
  Upgrade restrictedpython to 4.0b7
  Fix change
  ...

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment