New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor platform for Rova Garbage Collection #18868

Merged
merged 13 commits into from Jan 30, 2019

Conversation

Projects
None yet
6 participants
@GidoHakvoort
Copy link
Contributor

GidoHakvoort commented Nov 30, 2018

Description:

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7780

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: rova
    zip_code: YOUR_ZIP_CODE
    house_number: YOUR_HOUSE_NUMBER
    name: Rova
    monitored_conditions:
      - bio
      - paper
      - plastic
      - residual

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Show resolved Hide resolved homeassistant/components/sensor/rova.py
Show resolved Hide resolved homeassistant/components/sensor/rova.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/rova.py Outdated

@GidoHakvoort GidoHakvoort force-pushed the GidoHakvoort:rova branch from 03f3cfe to 485a9b0 Dec 4, 2018

GidoHakvoort added some commits Nov 30, 2018

Update async to new syntax
Added async_update to sensor class
Added Throttle to Rova update function
Minor code style changes

@GidoHakvoort GidoHakvoort force-pushed the GidoHakvoort:rova branch from 485a9b0 to 6605b15 Dec 4, 2018

@GidoHakvoort GidoHakvoort force-pushed the GidoHakvoort:rova branch from 6605b15 to 9aeb489 Dec 5, 2018

@wafflebot wafflebot bot removed the in progress label Dec 5, 2018

@GidoHakvoort GidoHakvoort deleted the GidoHakvoort:rova branch Dec 5, 2018

@GidoHakvoort GidoHakvoort restored the GidoHakvoort:rova branch Dec 5, 2018

@GidoHakvoort GidoHakvoort reopened this Dec 5, 2018

@wafflebot wafflebot bot added the in progress label Dec 5, 2018

@GidoHakvoort GidoHakvoort referenced this pull request Dec 8, 2018

Merged

Added documentation for ROVA sensor #7780

2 of 2 tasks complete
Update debug to error messages
Change CONF_MONITORED_VARIABLES to CONF_MONITORED_CONDITIONS
Update async update call to normal update
@fabaff
Copy link
Member

fabaff left a comment

Just some comment to get the review process started.

Update requirements to rova v0.0.2
Add address check to see if ROVA collects in the given area
Rename entity names to English
Add json_key to Sensor entities
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! Just one comment to fix, then we can merge.

Show resolved Hide resolved homeassistant/components/sensor/rova.py Outdated
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 29, 2019

Can be merged when build passes.

@GidoHakvoort GidoHakvoort reopened this Jan 30, 2019

@wafflebot wafflebot bot added in progress and removed in progress labels Jan 30, 2019

@MartinHjelmare MartinHjelmare merged commit 542160f into home-assistant:dev Jan 30, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 93.014%
Details

@wafflebot wafflebot bot removed the in progress label Jan 30, 2019

@GidoHakvoort GidoHakvoort deleted the GidoHakvoort:rova branch Feb 2, 2019

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment