New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect if ipv4/ipv6 is used for cert_expiry #18916

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
4 participants
@speedmann
Copy link
Contributor

speedmann commented Dec 2, 2018

Fixes #18818
Python sockets use ipv4 per default. If the domain which should be checked
only has an ipv6 record, socket creation errors out with
[Errno -2] Name or service not known
This fix tries to guess the protocol family and creates the socket
with the correct family type

Description:

Related issue (if applicable): fixes #18818

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Automatically detect if ipv4/ipv6 is used for cert_expiry
Fixes #18818
Python sockets use ipv4 per default. If the domain which should be checked
only has an ipv6 record, socket creation errors out with
`[Errno -2] Name or service not known`
This fix tries to guess the protocol family and creates the socket
with the correct family type
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Dec 2, 2018

Hi @speedmann,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Dec 2, 2018

@speedmann

This comment has been minimized.

Copy link
Contributor

speedmann commented Dec 7, 2018

Hi everyone,
is there something i still need to do for this to be able to be merged or do i just have to wait a little more?

@pvizeli

pvizeli approved these changes Dec 7, 2018

@pvizeli pvizeli merged commit 7edd241 into home-assistant:dev Dec 7, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 92.901%
Details

@wafflebot wafflebot bot removed the in progress label Dec 7, 2018

@speedmann speedmann deleted the speedmann:fix-18818 branch Dec 7, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 7, 2018

Merge branch 'dev' into current
* dev: (52 commits)
  Set lock status correctly for Schlage BE469 Z-Wave locks (home-assistant#18737)
  Upgrade Tibber lib (home-assistant#19098)
  Bump skybellpy version to fix api issue (home-assistant#19100)
  Automatically detect if ipv4/ipv6 is used for cert_expiry (home-assistant#18916)
  Upgrade pyatv to 0.3.12 (home-assistant#19085)
  Bump lakeside requirement to support more Eufy devices (home-assistant#19080)
  Set directv unavailable state when errors returned for longer then a minute (home-assistant#19014)
  Updated frontend to 20181207.0
  Force refresh Lovelace (home-assistant#19073)
  Upgrade aiolifx to 0.6.7 (home-assistant#19077)
  Fix missing colorTemperatureInKelvin from Alexa responses (home-assistant#19069)
  Add CM17A support (home-assistant#19041)
  Upgrade pylint to 2.2.2 (home-assistant#18750)
  Revert home-assistant#17745 (home-assistant#19064)
  Bumped version to 0.85.0.dev0
  Add support for more Tibber Pulse data (home-assistant#19033)
  Update locationsharinglib to 3.0.9 (home-assistant#19045)
  Implemented unique ID support for Fibaro hub integration (home-assistant#19055)
  Update pyhomematic to 0.1.53 (home-assistant#19056)
  Fix saving YAML as JSON with empty array (home-assistant#19057)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment