New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ZoneMinder availability to Home Assistant #18946

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@rohankapoorcom
Copy link
Member

rohankapoorcom commented Dec 3, 2018

Description:

Ties in the availability from ZoneMinder monitors to the camera and sensor entities created in Home Assistant.

Related issue (if applicable): fixes rohankapoorcom/zm-py#20
Depends on rohankapoorcom/zm-py#24

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! Ping me when it's out of WIP and I'll take a last look.

@rohankapoorcom rohankapoorcom changed the title WIP: Expose ZoneMinder availability to Home Assistant Expose ZoneMinder availability to Home Assistant Dec 9, 2018

@rohankapoorcom

This comment has been minimized.

Copy link
Member

rohankapoorcom commented Dec 9, 2018

@MartinHjelmare should be all set. I don't believe this needs a doc update.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 9, 2018

Can be merged when build passes.

@rohankapoorcom

This comment has been minimized.

Copy link
Member

rohankapoorcom commented Dec 14, 2018

@MartinHjelmare Can I get a merge please?

@MartinHjelmare MartinHjelmare merged commit e8ec74b into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-8.0e-05%) to 92.933%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:zoneminder-availability branch Dec 14, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Expose ZoneMinder availability to Home Assistant (home-assistant#18946)
* Expose ZoneMinder availability to Home Assistant

* Bump zm-py to 0.2.0 with the availability changes published

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@rohankapoorcom rohankapoorcom restored the rohankapoorcom:zoneminder-availability branch Jan 17, 2019

@rohankapoorcom rohankapoorcom referenced this pull request Jan 17, 2019

Merged

Add a Zoneminder availability sensor #20184

9 of 9 tasks complete

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:zoneminder-availability branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment