New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple RainMachine controllers #18989

Merged
merged 7 commits into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@bachya
Copy link
Contributor

bachya commented Dec 3, 2018

Description:

Even though multiple RainMachine controllers can be added via config UI, the same use case can't be accommodated via configuration.yaml. This PR rectifies that.

BREAKING CHANGE: the configuration.yaml format changes to the below.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7721

Example entry for configuration.yaml (if applicable):

rainmachine:
  controllers:
    - ip_address: !secret rainmachine_ip_address
      password: !secret rainmachine_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

bachya added some commits Dec 3, 2018

@bachya bachya force-pushed the bachya:multiple-rainmachine branch from e1df665 to 9f93076 Dec 5, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! Can be merged when build passes.

@bachya bachya merged commit 0870254 into home-assistant:dev Dec 5, 2018

4 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Dec 5, 2018

@bachya bachya deleted the bachya:multiple-rainmachine branch Dec 5, 2018

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment