New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unavailable when unreachable #19012

Merged
merged 4 commits into from Dec 14, 2018

Conversation

Projects
None yet
4 participants
@MaxG88
Copy link
Contributor

MaxG88 commented Dec 4, 2018

Description:

Sets the GPMDP component to unavailable when it can't be reached, instead of throwing errors in the logs.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@wafflebot wafflebot bot added the in progress label Dec 4, 2018

@MaxG88 MaxG88 changed the title Turn GPMDP Off When Unavailable Set GPMDP TO Unavailable When Unreachable Dec 4, 2018

@MaxG88 MaxG88 changed the title Set GPMDP TO Unavailable When Unreachable Set GPMDP To Unavailable When Unreachable Dec 4, 2018

@MaxG88 MaxG88 changed the title Set GPMDP To Unavailable When Unreachable Set unavailable when unreachable Dec 4, 2018

@fabaff
Copy link
Member

fabaff left a comment

New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@MaxG88

This comment has been minimized.

Copy link
Contributor

MaxG88 commented Dec 4, 2018

Sorry about that. I updated it.

volume_data = self.send_gpmdp_msg('volume', 'getVolume')
if volume_data is not None:
self._volume = volume_data['value'] / 100
except Exception:

This comment has been minimized.

@balloob

balloob Dec 5, 2018

Member

Please specify exception that you expect to catch.

This comment has been minimized.

@MaxG88

MaxG88 Dec 9, 2018

Contributor

I just specified it. Testing showed that the type was OSError, but it seems weird to me. Is this an exception type that normally appears?

MaxG88 and others added some commits Dec 9, 2018

@balloob balloob merged commit f95bd9c into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 92.892%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 14, 2018

Merge branch 'dev' into current
* dev: (88 commits)
  huawei_lte: Fetch only required data (home-assistant#17618)
  Adding support for Plum Lightpad (home-assistant#16576)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  Set InsteonEntity name to be combo of description and address. (home-assistant#17262)
  Device config for Fibaro hub integration (home-assistant#19171)
  Add air pollutants component (home-assistant#18707)
  Updated ELIQ Online sensor to async API (home-assistant#19248)
  Set unavailable when unreachable (home-assistant#19012)
  Make variable `entity_id` available to value_template for MQTT binary sensor (home-assistant#19195)
  home-assistant#17333: update to use DOMAIN constants and standards. (home-assistant#19242)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Bumped version to 0.84.2
  Fix call to super() (home-assistant#19279)
  Fix OwnTracks deadlocking (home-assistant#19260)
  Fix list (fixes home-assistant#19235) (home-assistant#19258)
  Add automation and script events to logbook filter events (home-assistant#19253)
  Bump aioasuswrt (home-assistant#19229)
  Review comments
  Move check to websocket
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Set unavailable when unreachable (home-assistant#19012)
* Turn GPMDP Off When Unavailable

* Update requirements_all.txt

* Specified Exception Type

* Update gpmdp.py

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment