Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emulated hue to set climate component temperature #19034

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@chilicheech
Copy link
Contributor

chilicheech commented Dec 5, 2018

Description:

This enables the emulated_hue component to set the temperature of climate devices.

The goal here is not to have the thermostat show up as a thermostat in Alexa, because with emulated hue it will show up as a light. The goal is simply to be able to say “Alexa, set the heater to 66” and have it set the thermostat temperature in that way. Things like “Alexa, raise the temperature” or “Alexa, I’m cold” or “Alexa, turn on the heater” won’t work. Only specifically setting the temperature will work.

This change makes it do the same thing it does for setting media player volume. The emulated_hue will “pretend” the thermostat is a light and use the brightness level as the temperature for the thermostat. This is the same thing it already does to media players. It uses the brightness level as the volume level.

Related issue (if applicable): This implements the feature requested here: https://community.home-assistant.io/t/emulated-hue-should-support-climate-thermostats/82702

Pull request in home-assistant.io with documentation (if applicable): There doesn't seem to be any home-assistant.io changes needed.

Example entry for configuration.yaml (if applicable):

emulated_hue:
  host_ip: x.x.x.x
  expose_by_default: false
  entities:
    climate.heater:
      hidden: false

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff changed the title allow emulated hue to set climate component temperature Allow emulated hue to set climate component temperature Dec 5, 2018

@amelchio
Copy link
Member

amelchio left a comment

If you can fix the conflicts that have emerged, I think this is good.

@chilicheech chilicheech force-pushed the chilicheech:hue-climate branch from 2d6854f to d77504c Mar 7, 2019

@chilicheech chilicheech requested review from andrewsayre , bachya , Danielhiversen , frenck , rytilahti , syssi and home-assistant/core as code owners Mar 7, 2019

@chilicheech chilicheech force-pushed the chilicheech:hue-climate branch 2 times, most recently from 2d6854f to 94dffcc Mar 7, 2019

@chilicheech chilicheech force-pushed the chilicheech:hue-climate branch 2 times, most recently from 8ef1bd5 to 7a339a8 Mar 7, 2019

@homeassistant homeassistant added cla-signed and removed cla-recheck labels Mar 7, 2019

@chilicheech chilicheech force-pushed the chilicheech:hue-climate branch from 7a339a8 to b8de0e6 Mar 7, 2019

@chilicheech chilicheech force-pushed the chilicheech:hue-climate branch from b8de0e6 to 8b05f05 Mar 7, 2019

@chilicheech

This comment has been minimized.

Copy link
Contributor Author

chilicheech commented Mar 8, 2019

@amelchio merge conflicts fixed 😄

@amelchio
Copy link
Member

amelchio left a comment

Looks good to me 👍

@amelchio amelchio merged commit 77dc759 into home-assistant:dev Mar 10, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0003%) to 92.754%
Details

@wafflebot wafflebot bot removed the in progress label Mar 10, 2019

@home-assistant home-assistant deleted a comment from homeassistant Mar 10, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.