New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last clean times to xiaomi vacuum #19043

Merged
merged 2 commits into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@rytilahti
Copy link
Contributor

rytilahti commented Dec 5, 2018

Description:

Add start and stop times of the last cleaning, useful for displaying or scheduling based on their value. The keys are the same as used by neato platform:

clean_start: 2018-12-03T14:15:16
clean_stop: 2018-12-03T14:39:19

Continuation of #17558 (can't reopen after a forced push). This is ready to be merged when #19042 gets merged.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

rytilahti added some commits Oct 17, 2018

Add last clean times to xiaomi vacuum
The keys are the same as used by neato platform.
@balloob

balloob approved these changes Dec 5, 2018

@syssi

syssi approved these changes Dec 5, 2018

@syssi syssi merged commit bc69309 into home-assistant:dev Dec 5, 2018

4 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Dec 5, 2018

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

@rytilahti rytilahti deleted the rytilahti:xiaomi_last_clean_time branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment