New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZHA device handler library #19099

Merged
merged 10 commits into from Dec 12, 2018

Conversation

Projects
None yet
5 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Dec 7, 2018

Description:

Adds support for additional devices and functionality by adding another library to ZHA. This library implements quirks functionality in Zigpy specifically for ZHA in HA. The library can be found here: https://pypi.org/project/zha-quirks/. This was implemented behind a toggle in HA and therefore can be turned on and off by changing a configuration option. No other input is needed from the user.

depends on functionality in #19095 and should not be merged until that is.

Docs PR: home-assistant/home-assistant.io#7808

dmulcahey added some commits Dec 7, 2018

dmulcahey added some commits Dec 7, 2018

@dmulcahey dmulcahey closed this Dec 7, 2018

@dmulcahey dmulcahey reopened this Dec 7, 2018

@wafflebot wafflebot bot added in progress and removed in progress labels Dec 7, 2018

@dmulcahey dmulcahey closed this Dec 9, 2018

@wafflebot wafflebot bot removed the in progress label Dec 9, 2018

@dmulcahey dmulcahey changed the title ZHA - Add device handler library WIP - ZHA - Add device handler library Dec 10, 2018

@dmulcahey dmulcahey reopened this Dec 10, 2018

@wafflebot wafflebot bot added the in progress label Dec 10, 2018

dmulcahey added some commits Dec 10, 2018

Remove fix in favor of #19141
#19141 should be what ultimately corrects this issue.

@dmulcahey dmulcahey changed the title WIP - ZHA - Add device handler library ZHA - Add device handler library Dec 10, 2018

@fabaff fabaff changed the title ZHA - Add device handler library Add ZHA device handler library Dec 12, 2018

@fabaff fabaff added the docs-missing label Dec 12, 2018

@fabaff

This comment has been minimized.

Copy link
Member

fabaff commented Dec 12, 2018

This PR requires a documentation update as there is a new option.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

I've noticed that we missed to exclude a zha package module from coverage calculation in one of the later PRs. Please add the event module to .coveragerc.

Show resolved Hide resolved homeassistant/components/zha/__init__.py
@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Dec 12, 2018

@MartinHjelmare .coveragerc updated

@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Dec 12, 2018

@fabaff all set.

@dmulcahey dmulcahey referenced this pull request Dec 12, 2018

Merged

Update ZHA docs for quirks mode flag #7808

0 of 2 tasks complete
@fabaff

fabaff approved these changes Dec 12, 2018

Copy link
Member

fabaff left a comment

Thanks 🐦

@fabaff fabaff merged commit 031ee71 into home-assistant:dev Dec 12, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 92.893%
Details

@wafflebot wafflebot bot removed the in progress label Dec 12, 2018

@dmulcahey dmulcahey deleted the dmulcahey:dm/test-zha-event-foundation branch Dec 26, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment