New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't avoid async_schedule_update_ha_state by returning false #19102

Merged
merged 1 commit into from Dec 8, 2018

Conversation

@syssi
Copy link
Member

syssi commented Dec 7, 2018

Description:

If parse_data returns true async_schedule_update_ha_state is triggered. At the moment some attribute updates doesn't propagate because update_ha_state isn't called often enough.

Related issue (if applicable): fixes #19089

https://community.home-assistant.io/t/xiaomi-button-no-longer-registers-single-or-double-press/83129

@rytilahti

This comment has been minimized.

Copy link
Contributor

rytilahti commented Dec 7, 2018

Thanks @syssi! This fixes the issue for me, but as I have no familiarity with this code (and don't know the reasoning for that filter..) better wait for Daniel to chime in :-)

@Danielhiversen

This comment has been minimized.

Copy link
Member

Danielhiversen commented Dec 8, 2018

👍

@Danielhiversen Danielhiversen merged commit f2f6496 into home-assistant:dev Dec 8, 2018

4 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Dec 8, 2018

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Dec 10, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into feature/nmbs-sensor

* 'dev' of https://github.com/home-assistant/home-assistant: (325 commits)
  Update translations
  Updated frontend to 20181210.0
  Lovelace using storage (home-assistant#19101)
  Update pygtfs to upstream's 0.1.5 (home-assistant#19151)
  Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107)
  Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140)
  Update geizhals dependency (home-assistant#19152)
  Upgrade mypy to 0.650 (home-assistant#19150)
  Upgrade upcloud-api to 0.4.3
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Upgrade slacker to 0.12.0
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  update edp_redy version (home-assistant#19078)
  Add Philips Moonlight Bedside Lamp support (home-assistant#18496)
  Upgrade Mill library (home-assistant#19117)
  Don't avoid async_schedule_update_ha_state by returning false (home-assistant#19102)
  Fix the Xiaomi Aqara Cube rotate event of the LAN protocol 2.0 (Closes: home-assistant#18199) (home-assistant#19104)
  ...

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 10, 2018

Merge branch 'dev' into current
* dev:
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  update edp_redy version (home-assistant#19078)
  Add Philips Moonlight Bedside Lamp support (home-assistant#18496)
  Upgrade Mill library (home-assistant#19117)
  Don't avoid async_schedule_update_ha_state by returning false (home-assistant#19102)
  Fix the Xiaomi Aqara Cube rotate event of the LAN protocol 2.0 (Closes: home-assistant#18199) (home-assistant#19104)
  Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.hmi205) (home-assistant#19071)

@balloob balloob added this to the 0.84.2 milestone Dec 13, 2018

balloob added a commit that referenced this pull request Dec 14, 2018

@balloob balloob referenced this pull request Dec 14, 2018

Merged

0.84.2 #19281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment