New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed doorbird config without events (empty list) #19121

Merged
merged 1 commit into from Dec 9, 2018

Conversation

Projects
None yet
3 participants
@basschipper
Copy link
Contributor

basschipper commented Dec 8, 2018

Description:

When not specifying any doorbird events the events variable is a empty list.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

When events is a empty list:

doorbird:
  token: !secret doorbird_token
  devices:
    name: Frontdoor
    host: 1.2.3.4
    username: !secret doorbird_username
    password: !secret doorbird_password

So without:

    monitored_conditions:
      - doorbell
      - motion

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Dec 9, 2018

Copy link
Member

fabaff left a comment

Thanks 🐦

@fabaff fabaff merged commit 4b4f51f into home-assistant:dev Dec 9, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 92.933%
Details

@wafflebot wafflebot bot removed the in progress label Dec 9, 2018

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Dec 10, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into feature/nmbs-sensor

* 'dev' of https://github.com/home-assistant/home-assistant: (325 commits)
  Update translations
  Updated frontend to 20181210.0
  Lovelace using storage (home-assistant#19101)
  Update pygtfs to upstream's 0.1.5 (home-assistant#19151)
  Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107)
  Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140)
  Update geizhals dependency (home-assistant#19152)
  Upgrade mypy to 0.650 (home-assistant#19150)
  Upgrade upcloud-api to 0.4.3
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Upgrade slacker to 0.12.0
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  update edp_redy version (home-assistant#19078)
  Add Philips Moonlight Bedside Lamp support (home-assistant#18496)
  Upgrade Mill library (home-assistant#19117)
  Don't avoid async_schedule_update_ha_state by returning false (home-assistant#19102)
  Fix the Xiaomi Aqara Cube rotate event of the LAN protocol 2.0 (Closes: home-assistant#18199) (home-assistant#19104)
  ...

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 10, 2018

Merge branch 'dev' into current
* dev:
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  update edp_redy version (home-assistant#19078)
  Add Philips Moonlight Bedside Lamp support (home-assistant#18496)
  Upgrade Mill library (home-assistant#19117)
  Don't avoid async_schedule_update_ha_state by returning false (home-assistant#19102)
  Fix the Xiaomi Aqara Cube rotate event of the LAN protocol 2.0 (Closes: home-assistant#18199) (home-assistant#19104)
  Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.hmi205) (home-assistant#19071)

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Dec 12, 2018

Merge remote-tracking branch 'origin/dev' into feature/vrtnws-sensor
* origin/dev: (333 commits)
  Add raw service data to event (home-assistant#19163)
  Updated frontend to 20181210.1
  Google assistant fix target temp for *F values. (home-assistant#19083)
  Fix lovelace save (home-assistant#19162)
  Drop OwnTracks bad packets (home-assistant#19161)
  Update translations
  Updated frontend to 20181210.0
  Lovelace using storage (home-assistant#19101)
  Update pygtfs to upstream's 0.1.5 (home-assistant#19151)
  Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107)
  Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140)
  Update geizhals dependency (home-assistant#19152)
  Upgrade mypy to 0.650 (home-assistant#19150)
  Upgrade upcloud-api to 0.4.3
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Upgrade slacker to 0.12.0
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment