New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satel integra monitor outputs #19149

Merged
merged 3 commits into from Dec 17, 2018

Conversation

Projects
None yet
5 participants
@c-soft
Copy link
Contributor

c-soft commented Dec 9, 2018

Description:

Added support for output monitoring for Satel Integra alarm.
Fixed initialization issue that prevented component from asking Satel about its state during start.

Related issue (if applicable): relates to: #10616

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7785

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@c-soft

This comment has been minimized.

Copy link
Contributor

c-soft commented Dec 9, 2018

Fixed the email issue.

@c-soft

This comment has been minimized.

Copy link
Contributor

c-soft commented on fcea684 Dec 10, 2018

Email issue fixed.

@balloob balloob added cla-recheck and removed cla-error labels Dec 10, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Good!

@home-assistant home-assistant deleted a comment from homeassistant Dec 15, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 15, 2018

Can be merged when build passes.

@c-soft

This comment has been minimized.

Copy link
Contributor

c-soft commented Dec 15, 2018

@MartinHjelmare thank you for the review!

@cgarwood cgarwood merged commit 6c8ed86 into home-assistant:dev Dec 17, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 92.881%
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Satel integra monitor outputs (home-assistant#19149)
* Adjusted api for new library version.

* Added support for output monitoring. Added initial status check for the alarm.

* Added default values to the configuration as per review notes.

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment