New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCAN_INTERVAL #19186

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
5 participants
@fabaff
Copy link
Member

fabaff commented Dec 11, 2018

Description:

Use the same interval as for the sensor. It's a sensor platform and should also behave as one.

Was spotted during the review of the air_pollutants component by @MartinHjelmare.

Example entry for configuration.yaml (if applicable):

weather:
  - platform: demo

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Do we need to mark this breaking change, since the default scan interval will change?

Show resolved Hide resolved homeassistant/components/weather/__init__.py Outdated
@fabaff

This comment has been minimized.

Copy link
Member

fabaff commented Dec 11, 2018

Doesn't harm to add it to the release notes. I doubt that people will see an impact but better be safe than sorry.

Breaking change:
The default interval of the weather component was aligned with the sensor component and is now 30 seconds instead of 15 seconds.

@pvizeli pvizeli merged commit 3e7b908 into dev Dec 11, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 92.973%
Details

@wafflebot wafflebot bot removed the in progress label Dec 11, 2018

@delete-merged-branch delete-merged-branch bot deleted the weather-interval branch Dec 11, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 11, 2018

Merge branch 'dev' into current
* dev: (26 commits)
  Move daikin to package (home-assistant#19187)
  Restore states for RFLink devices (home-assistant#18816)
  Add SCAN_INTERVAL (home-assistant#19186)
  Enable alarmdecoder to see open/close state of bypassed RF zones when armed (home-assistant#18477)
  Updated frontend to 20181211.0
  Fix cloud defaults (home-assistant#19172)
  TelldusLive config flow (home-assistant#18758)
  ZHA - Event foundation (home-assistant#19095)
  Add raw service data to event (home-assistant#19163)
  Updated frontend to 20181210.1
  Google assistant fix target temp for *F values. (home-assistant#19083)
  Fix lovelace save (home-assistant#19162)
  Drop OwnTracks bad packets (home-assistant#19161)
  Update translations
  Updated frontend to 20181210.0
  Lovelace using storage (home-assistant#19101)
  Update pygtfs to upstream's 0.1.5 (home-assistant#19151)
  Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107)
  Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140)
  Update geizhals dependency (home-assistant#19152)
  ...

ENTITY_ID_FORMAT = DOMAIN + '.{}'

SCAN_INTERVAL = timedelta(seconds=30)

This comment has been minimized.

@balloob

balloob Jan 10, 2019

Member

This seems overaggressive for a weather API.

This comment has been minimized.

@balloob

balloob Jan 10, 2019

Member

Did you mean 30 minutes ?

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment