New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check for duplicated entity_id #19194

Merged
merged 3 commits into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@emontnemery
Copy link
Contributor

emontnemery commented Dec 11, 2018

Description:

Add check for new entity_id in hass.states

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery emontnemery requested a review from home-assistant/core as a code owner Dec 11, 2018

@wafflebot wafflebot bot added the in progress label Dec 11, 2018

@balloob balloob closed this Dec 11, 2018

@wafflebot wafflebot bot removed the in progress label Dec 11, 2018

@emontnemery emontnemery reopened this Dec 11, 2018

@wafflebot wafflebot bot added the in progress label Dec 11, 2018

@emontnemery

This comment has been minimized.

Copy link
Contributor

emontnemery commented Dec 11, 2018

Check moved to websocket handler as discussed on chat.

@emontnemery emontnemery added this to the 0.84.2 milestone Dec 13, 2018

@balloob balloob merged commit eada1a1 into home-assistant:dev Dec 13, 2018

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 92.873%
Details

@wafflebot wafflebot bot removed the in progress label Dec 13, 2018

@emontnemery emontnemery referenced this pull request Dec 16, 2018

Merged

Fix not being able to update entities #19344

3 of 3 tasks complete

@emontnemery emontnemery deleted the emontnemery:update_registry_entity_id branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment