New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZHA entity state on ZigBee zdo device announce #19208

Merged
merged 4 commits into from Dec 22, 2018

Conversation

Projects
None yet
3 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Dec 11, 2018

CC @Adminiuga Thanks for helping me test this!

@fabaff fabaff changed the title ZHA - update entity state on zigbee zdo device announce Update entity state on ZigBee ZDO device announce Dec 12, 2018

@fabaff fabaff changed the title Update entity state on ZigBee ZDO device announce Update entity state on ZigBee zdo device announce Dec 12, 2018

@dmulcahey dmulcahey changed the title Update entity state on ZigBee zdo device announce Update ZHA entity state on ZigBee zdo device announce Dec 12, 2018

@dmulcahey dmulcahey closed this Dec 19, 2018

@wafflebot wafflebot bot removed the in progress label Dec 19, 2018

@dmulcahey dmulcahey reopened this Dec 19, 2018

@wafflebot wafflebot bot added the in progress label Dec 19, 2018

self.async_schedule_update_ha_state(force_refresh=True)

@callback
def permit_duration(self, permit_duration):

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 22, 2018

Member

Is this overwritten in child classes?

This comment has been minimized.

@dmulcahey

dmulcahey Dec 22, 2018

Contributor

no it is a side effect of how zigpy event listeners work. If you don't implement all events that an emitter can emit it throws warnings / errors and pollutes the logs. So, because the ZDO listener can emit this event we have to have a handler for it.

@MartinHjelmare MartinHjelmare merged commit 4bdb21a into home-assistant:dev Dec 22, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 93.039%
Details

@wafflebot wafflebot bot removed the in progress label Dec 22, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Update ZHA entity state on ZigBee zdo device announce (home-assistant…
…#19208)

* call async_update if defined on device_announce

* lint

* change update method

* remove unneeded listener

@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-zdo-announce-entity-update branch Dec 26, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment