New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package data attribute to 17track.net summary sensors #19213

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

bachya commented Dec 12, 2018

Description:

From a forum request: users want 17track.net summary sensors to include a JSON attribute containing the packages applicable to that status (for easier display via a table card in Lovelace). This PR takes care of that.

The PR also fixes an issue wherein 17track.net sensors couldn't be used in Jinja templates because of their entity ID.

BREAKING CHANGE: In order to fix the below bug, default entity_ids will change (for example, sensor.17track_packages_delivered will change to sensor.seventeentrack_packages_delivered).

Related issue (if applicable): fixes #19212

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: seventeentrack
    username: !secret 17track_email
    password: !secret 17track_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@bachya bachya self-assigned this Dec 12, 2018

@wafflebot wafflebot bot added the in progress label Dec 12, 2018

@fabaff fabaff changed the title 17track.net: Add package data attribute to summary sensors Add package data attribute to 17track.net summary sensors Dec 12, 2018

@MartinHjelmare MartinHjelmare merged commit f8438e9 into home-assistant:dev Dec 12, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0005%) to 92.877%
Details

@wafflebot wafflebot bot removed the in progress label Dec 12, 2018

@bachya bachya deleted the bachya:17track-updates branch Dec 12, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add package data attribute to 17track.net summary sensors (home-assis…
…tant#19213)

* 17track.net: Add package data attribute to summary sensors

* Member comments

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment