New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioasuswrt #19229

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
7 participants
@kennedyshead
Copy link
Contributor

kennedyshead commented Dec 12, 2018

Description:

This will hopefully take care of telnet issues.
It will give a more stable ul/dl sensor

Related issue (if applicable):
fixes #19031
fixes #19138
fixes #18492
fixes #18997

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

MagnusKnutas added some commits Dec 12, 2018

@marchingphoenix

This comment has been minimized.

Copy link
Contributor

marchingphoenix commented Dec 12, 2018

Does this one also fix #18997 ? (your part at least)

@kennedyshead

This comment has been minimized.

Copy link
Contributor

kennedyshead commented Dec 12, 2018

Does this one also fix #18997 ? (your part at least)

Yes, but as stated in the issue, there is much log in asyncssh that not will be solved.

@kennedyshead

This comment has been minimized.

Copy link
Contributor

kennedyshead commented Dec 12, 2018

@balloob If you do any more 0.84 releases this should be included I think.

@marchingphoenix

This comment has been minimized.

Copy link
Contributor

marchingphoenix commented Dec 12, 2018

Yes, but as stated in the issue, there is much log in asyncssh that not will be solved.

Yep, i'm cool with that. Just asking so this PR closes that issue for us :)

@balloob balloob added this to the 0.84.2 milestone Dec 12, 2018

@balloob balloob merged commit 8c6b9b5 into home-assistant:dev Dec 12, 2018

4 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Dec 12, 2018

balloob added a commit that referenced this pull request Dec 14, 2018

Bump aioasuswrt (#19229)
* bump aioasuswrt version

* run gen_requirements

@balloob balloob referenced this pull request Dec 14, 2018

Merged

0.84.2 #19281

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 14, 2018

Merge branch 'dev' into current
* dev: (88 commits)
  huawei_lte: Fetch only required data (home-assistant#17618)
  Adding support for Plum Lightpad (home-assistant#16576)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  Set InsteonEntity name to be combo of description and address. (home-assistant#17262)
  Device config for Fibaro hub integration (home-assistant#19171)
  Add air pollutants component (home-assistant#18707)
  Updated ELIQ Online sensor to async API (home-assistant#19248)
  Set unavailable when unreachable (home-assistant#19012)
  Make variable `entity_id` available to value_template for MQTT binary sensor (home-assistant#19195)
  home-assistant#17333: update to use DOMAIN constants and standards. (home-assistant#19242)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Bumped version to 0.84.2
  Fix call to super() (home-assistant#19279)
  Fix OwnTracks deadlocking (home-assistant#19260)
  Fix list (fixes home-assistant#19235) (home-assistant#19258)
  Add automation and script events to logbook filter events (home-assistant#19253)
  Bump aioasuswrt (home-assistant#19229)
  Review comments
  Move check to websocket
  ...

@kennedyshead kennedyshead deleted the kennedyshead:bump_asus branch Dec 18, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Bump aioasuswrt (home-assistant#19229)
* bump aioasuswrt version

* run gen_requirements
@B1tMaster

This comment has been minimized.

Copy link
Contributor

B1tMaster commented Jan 8, 2019

What version of HA will this go into? It is still spamming at 0.84.5

@kennedyshead

This comment has been minimized.

Copy link
Contributor

kennedyshead commented Jan 8, 2019

What version of HA will this go into? It is still spamming at 0.84.5

There is no log from the HA integration left, if there is any log-spamming it's from asyncssh.

@vince1310

This comment has been minimized.

Copy link

vince1310 commented Jan 9, 2019

Agree with @B1tMaster - still seeing this spamming in 0.84.6

@marchingphoenix

This comment has been minimized.

Copy link
Contributor

marchingphoenix commented Jan 9, 2019

@vince1310 per OP any remaining logs will be coming from other packages. If you're still having problems, open an issue. Do not have conversations on a merged PR.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jan 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.